fix(system): correct service, update repair, and legacy imports by virtualtable · Pull Request #4966 · ChrisTitusTech/winutil

virtualtable · 2026-08-11T09:35:29Z

Summary

pass the PowerShell 5 delayed-start arguments to sc.exe with the required spacing and report non-zero exit codes
remove the WSUS client registry values with PowerShell registry commands instead of malformed REG DELETE paths
import historical grouped WinUtil configurations while ignoring the legacy Install package metadata and retaining strict validation for selection keys
merge the current main branch and add regression coverage for the historical import shape

Validation

.\Compile.ps1
Pester 5.8.0 full suite: 562 passed, 0 failed
focused UI-state suite: 20 passed, 0 failed
PowerShell Script Analyzer completed with only existing accepted repository warnings
local Codex review loop completed; no actionable findings remain
legacy fixture confirmed apps, tweaks, toggles, and features import without treating package metadata as selections

Manual validation

The destructive service and Windows Update repair operations were not run against the host. Their behavior is covered by source review and focused helper tests.

…ns guard

coderabbitai · 2026-08-11T09:35:54Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 507008ca-1cb8-4a41-a2ca-b254672bc285

📥 Commits

Reviewing files that changed from the base of the PR and between eba5142 and cb44dbe.

📒 Files selected for processing (2)

functions/public/Invoke-WPFImpex.ps1
pester/ui-state.Tests.ps1

Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review.

📝 Walkthrough

Summary by CodeRabbit

Bug Fixes
- Fixed delayed automatic service startup configuration.
- Improved WSUS client cleanup by reliably removing stale identification values.
- Improved configuration imports by supporting legacy formats and validating all selections before applying changes.
- Prevented malformed imports from partially replacing existing selections.
Tests
- Added coverage for importing legacy configurations with grouped selections, ensuring metadata is handled correctly without errors.

Walkthrough

The changes correct delayed service startup configuration, replace WSUS registry deletion processes with PowerShell commands, and improve legacy import handling with atomic selection replacement and regression coverage.

Changes

Windows utility maintenance

Layer / File(s)	Summary
Service startup validation `functions/private/Set-WinUtilService.ps1`	The delayed automatic startup command now passes `start= delayed-auto` and throws when `sc.exe` returns a nonzero exit code.
WSUS registry cleanup `functions/public/Invoke-WPFFixesUpdate.ps1`	The `AccountDomainSid`, `PingID`, and `SusClientId` values are removed with `Remove-ItemProperty` while retaining silent error handling.
Legacy import validation `functions/public/Invoke-WPFImpex.ps1`, `pester/ui-state.Tests.ps1`	Legacy configurations with `Install` metadata are flattened without importing the metadata. Imports validate selections before replacing existing state, with regression coverage for grouped legacy selections.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to cb44d

The PR updates service repair, Windows Update repair, and legacy import behavior with focused and full test validation reported as passing; no actionable merge-blocking risk remains.

Possibly related PRs

ChrisTitusTech/winutil#4911: Both changes refine legacy JSON import handling and related UI-state tests.
ChrisTitusTech/winutil#4994: This change extends the import validation and replacement behavior for legacy configurations.

Suggested labels: bug

Suggested reviewers: christitustech

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly summarizes the service, update repair, and legacy import fixes in the changeset.
Description check	✅ Passed	The description directly explains the implemented fixes, compatibility changes, tests, and validation results.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@functions/private/Set-WinUtilService.ps1`:
- Line 36: Update the service configuration flow around sc.exe config in
Set-WinUtilService so it checks $LASTEXITCODE immediately after the command and
throws when the exit code is non-zero. Keep the success log only on the
successful path, allowing the existing catch handling to report configuration
failures.

In `@functions/public/Invoke-WPFImpex.ps1`:
- Around line 76-86: The legacy-import flattening logic around $flattenedJson
must exclude the metadata object represented by the Install property before
Update-WinUtilSelections is called, retaining only selection identifiers and
preserving flat-import behavior. Add a regression fixture that verifies legacy
and flat imports produce equivalent selections.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9b64fa5d-4c41-4263-b7f5-9ee0229a183c

📥 Commits

Reviewing files that changed from the base of the PR and between ea5de27 and 60a541d.

📒 Files selected for processing (4)

functions/private/Set-WinUtilDNS.ps1
functions/private/Set-WinUtilService.ps1
functions/public/Invoke-WPFFixesUpdate.ps1
functions/public/Invoke-WPFImpex.ps1

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 60a541d1cf

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

virtualtable · 2026-08-11T09:44:47Z

@coderabbitai review

coderabbitai · 2026-08-11T09:44:55Z

⚠️ Action not completed

Already reviewed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

virtualtable · 2026-08-11T21:25:10Z

@coderabbitai review

coderabbitai · 2026-08-11T21:25:15Z

⚠️ Action not completed

Already reviewed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

mewclouds · 2026-08-11T22:30:23Z

Thanks for working on this. I raised the same concern on #4911, but a decision has not been made in #4877 about what backward compatibility should mean here.

The backup format changed on February 17, almost six months ago. It is up to Chris to decide whether full compatibility is necessary or partial import is acceptable.

This skips the old Install section. That may be necessary because the old winget and choco metadata cannot be passed directly to the current selection importer, but it also means the backup is not necessarily fully restored. That needs an explicit product decision rather than being presented as complete backward compatibility.

I also cannot verify this was tested. There is no legacy JSON fixture, import-path test, or example of the old input and expected selections.

Finally, every provider in config/dns.json has Primary6 and Secondary6, so the IPv6 guard is always true. IPv4-only DNS providers are very rare.

virtualtable · 2026-08-12T10:22:59Z

didnt know about #4877 and #4911, my bad. the legacy import thing was just to avoid the null key crash but yeah thats more of a product decision for chris on how far back compat should go. i can drop that + the ipv6 guard if youd prefer to keep this to just the sc.exe and reg fixes, lmk

mewclouds · 2026-08-12T17:40:24Z

didnt know about #4877 and #4911, my bad. the legacy import thing was just to avoid the null key crash but yeah thats more of a product decision for chris on how far back compat should go. i can drop that + the ipv6 guard if youd prefer to keep this to just the sc.exe and reg fixes, lmk

I'd say keep the legacy import implementation for now and lets wait for Chris' input. The IPv6 guard can be removed. Good work on the bugfixes 😄

virtualtable · 2026-08-13T10:15:45Z

sounds good, removed the ipv6 guard commit as suggested! leaving the rest for chris to review 👍

ChrisTitusTech

Reviewed the final branch after syncing with main. Local compile and all 562 Pester tests pass, all review threads are resolved, and both Codex and CodeRabbit review loops have no remaining actionable findings.

fix(system): correct sc.exe argument syntax, reg deletion, and ipv6 d…

60a541d

…ns guard

virtualtable requested a review from ChrisTitusTech as a code owner August 11, 2026 09:35

coderabbitai Bot requested changes Aug 11, 2026

View reviewed changes

Comment thread functions/private/Set-WinUtilService.ps1

Comment thread functions/public/Invoke-WPFImpex.ps1

chatgpt-codex-connector Bot reviewed Aug 11, 2026

View reviewed changes

Comment thread functions/public/Invoke-WPFImpex.ps1

fix(impex): exclude legacy Install metadata from flattened import

fb25e2b

coderabbitai Bot added the bug Something isn't working label Aug 11, 2026

fix(service): throw on non-zero LASTEXITCODE from sc.exe config

eba5142

coderabbitai Bot approved these changes Aug 11, 2026

View reviewed changes

refactor(dns): revert unnecessary ipv6 guard per review feedback

5e16ea9

coderabbitai Bot mentioned this pull request Aug 15, 2026

Fix legacy json import compatibility, UI sidebar refactor, and improved test coverage #4911

Merged

5 tasks

ChrisTitusTech added this to ChrisTitusTech Development Aug 17, 2026

ChrisTitusTech added 2 commits August 19, 2026 16:16

Merge remote-tracking branch 'origin/main' into pr-4966-update

55bbb15

test(impex): cover legacy config imports

cb44dbe

ChrisTitusTech changed the title ~~fix(system): correct sc.exe argument syntax, reg deletion, and ipv6 dns guard~~ fix(system): correct service, update repair, and legacy imports Aug 19, 2026

ChrisTitusTech approved these changes Aug 19, 2026

View reviewed changes

ChrisTitusTech merged commit 4b2fe55 into ChrisTitusTech:main Aug 19, 2026
5 checks passed

Uh oh!

Conversation

virtualtable commented Aug 11, 2026 • edited by ChrisTitusTech Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Manual validation

Uh oh!

coderabbitai Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

virtualtable commented Aug 11, 2026

Uh oh!

coderabbitai Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

virtualtable commented Aug 11, 2026

Uh oh!

coderabbitai Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mewclouds commented Aug 11, 2026

Uh oh!

virtualtable commented Aug 12, 2026

Uh oh!

mewclouds commented Aug 12, 2026

Uh oh!

virtualtable commented Aug 13, 2026

Uh oh!

ChrisTitusTech left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

virtualtable commented Aug 11, 2026 •

edited by ChrisTitusTech

Loading

coderabbitai Bot commented Aug 11, 2026 •

edited

Loading

coderabbitai Bot commented Aug 11, 2026 •

edited

Loading

coderabbitai Bot commented Aug 11, 2026 •

edited

Loading